Skip to content

Update Grace period for Tokens#2020

Closed
stephanieatte wants to merge 2 commits intomainfrom
stephanieatte-patch-2
Closed

Update Grace period for Tokens#2020
stephanieatte wants to merge 2 commits intomainfrom
stephanieatte-patch-2

Conversation

@stephanieatte
Copy link
Contributor

Notice about Agent Token Grace Period

@render
Copy link

render bot commented Apr 11, 2023

@github-actions github-actions bot added the agent label Apr 11, 2023
Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section you're editing says that tokens can only be created through the API, but your addition sounds like someone is creating a token through the UI. Does the section need to be updated to indicate that you can create a token through the UI, too?

It is possible to create multiple agent tokens using the GraphQL API. These tokens will show up on the Agents page in the UI, but can only be managed (created or revoked) using the API.

Co-authored-by: Michael Belton <119824349+mbelton-buildkite@users.noreply.github.com>
@mbelton-buildkite
Copy link
Contributor

@stephanieatte, I'm not sure if you saw my comment. There's no mention of what page someone is looking at when they can use this information. Where is someone creating a token that this grace period applies to?

@stephanieatte
Copy link
Contributor Author

@mbelton-buildkite you can definitely create API token in the UI. what happens is when the user creates it in the UI. It shows on the top of the page for about 10 minutes. So some user thought it was a security breach or something happening. Because usually when you create tokens on other websites it disappears right after

@mbelton-buildkite
Copy link
Contributor

It looks like this one hasn't been updated to address where this is happening in the UI and making sure it makes sense with the rest of the page.

@ozdenyilmaz
Copy link
Contributor

This PR is no longer needed. The PR wanted to add a note about a 10-minute grace period after creating a token where it remains visible. The current page already addresses this clearly on line 25–27:

📘 An agent token's value is only displayed once
As soon as the agent token's value is displayed, copy its value and save it in a secure location.

The page also had outstanding review feedback that was never addressed. It can be safely closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants